Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isPassportNumber): add regex for Azerbaijan #2061

Closed
wants to merge 3 commits into from

Conversation

djeks922
Copy link
Contributor

@djeks922 djeks922 commented Oct 7, 2022

Checklist

  • ✅ PR contains only changes related; no stray files, etc.
  • ✅ README updated (where applicable)
  • ✅ Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b2ccdd2) compared to base (531dc7f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2061   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @djeks922 ! LGTM 🎉 Please fix merge conflict and it should be good to go !

@tux-tn tux-tn added 🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. labels Oct 19, 2022
@djeks922
Copy link
Contributor Author

Thanks for feedback, Merge request was fixed! Here you go

@djeks922
Copy link
Contributor Author

@tux-tn

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you @djeks922 , is you PR part of Hacktoberfest 2022?

@djeks922
Copy link
Contributor Author

Welcome @tux-tn, No, I don't. What is this exactly ?

@tux-tn
Copy link
Member

tux-tn commented Oct 20, 2022

Check https://hacktoberfest.com/ . I can add the appropriate label in case you want to make your contribution as part of the event.

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Oct 20, 2022
@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023
@profnandaa
Copy link
Member

will get in #2164

@@ -153,7 +153,7 @@ Validator | Description
**isMultibyte(str)** | check if the string contains one or more multibyte chars.
**isNumeric(str [, options])** | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{no_symbols: false}` it also has locale as an option. If `no_symbols` is true, the validator will reject numeric strings that feature a symbol (e.g. `+`, `-`, or `.`).<br/><br/>`locale` determine the decimal separator and is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'es-ES', 'fr-FR', 'fr-CA', 'hu-HU', 'it-IT', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'sl-SI', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'tr-TR', 'uk-UA']`.
**isOctal(str)** | check if the string is a valid octal number.
**isPassportNumber(str, countryCode)** | check if the string is a valid passport number.<br/><br/>(countryCode is one of `[ 'AM', 'AR', 'AT', 'AU', 'BE', 'BG', 'BY', 'BR', 'CA', 'CH', 'CN', 'CY', 'CZ', 'DE', 'DK', 'DZ', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HR', 'HU', 'IE' 'IN', 'IR', 'ID', 'IS', 'IT', 'JP', 'KR', 'LT', 'LU', 'LV', 'LY', 'MT', 'MX', 'MY', 'MZ', 'NL', 'PL', 'PT', 'RO', 'RU', 'SE', 'SL', 'SK', 'TH', 'TR', 'UA', 'US' ]`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'TH' should not be removed here @profnandaa

profnandaa added a commit that referenced this pull request Feb 2, 2023
* maintenance: clean up #2061

---------

Co-authored-by: djeks922 <djeks922@gmail.com>
@profnandaa
Copy link
Member

merged in #2164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing. PR/combined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants